BXC-4719 archive project #109
Conversation
src/main/java/edu/unc/lib/boxc/migration/cdm/services/ArchiveProjectService.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/ArchiveProjectService.java
Outdated
Show resolved
Hide resolved
| int numberArchivedProjects = countArchivedProjects(directory); | ||
| ObjectNode objectNode = mapper.createObjectNode(); | ||
| objectNode.put(ARCHIVED_PROJECTS, numberArchivedProjects); | ||
| arrayNode.add(objectNode); |
There was a problem hiding this comment.
Hm, i think it's going to be confusing if the result from this service is a list of projects, and then one of the entries in the list is just a count archived projects. Will probably also mess up the table in the admin UI. Maybe we can add this count to one of the status commands instead?
I'm also wondering if this service should know how to list archived projects in the .archived subdirectory, and include them in the regular results. Otherwise it seems like we'll never have any results with status = archived. It'd probably just mean making lines 60-81 into a helper method and then calling it on both the base directory and the archived subdirectory. If we do that, we might want to add an option so that archived projects only get included if the option is set, like --include-archived.
There was a problem hiding this comment.
I ended up removing the countArchivedProjects method. I don't know if it would work in one of the status commands since I think those commands get the status for one project and not multiple. We probably don't need the archived project count anymore now that we added an --include-archived option?
There was a problem hiding this comment.
yes you're right, it wouldn't make sense in the status commands, so removing the stat makes sense
…chiveProject to archiveProjects, throw error, remove countArchivedProjects method, add --include-archived option to listProjects cmd
src/main/java/edu/unc/lib/boxc/migration/cdm/services/ArchiveProjectsService.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/ListProjectsService.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/ListProjectsService.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/unc/lib/boxc/migration/cdm/services/ListProjectsService.java
Outdated
Show resolved
Hide resolved
https://unclibrary.atlassian.net/browse/BXC-4719
archiveservice and command to archive a list of chompb projects, which moves said projects to an "archived" folderlist_projectsservice and command to count the number of archived projects