Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BXC-4648 - Don't create empty SIPs #101

Merged
merged 2 commits into from
Jul 25, 2024
Merged

BXC-4648 - Don't create empty SIPs #101

merged 2 commits into from
Jul 25, 2024

Conversation

bbpennel
Copy link
Member

@bbpennel bbpennel commented Jul 24, 2024

https://unclibrary.atlassian.net/browse/BXC-4648

  • Delete SIPs if they do not contain any works. Indicate that a SIP was removed because of this in the output of the generate command, and list the number of works per SIP.
  • Moves TDB directory out of the SIP directory into a temp folder. This resolves a long standing deletion warning that was being logged after sip generate, prevents having leftover sip folders, and is slightly faster.

… removed because of this in the output of the generate command, and list the number of works per SIP.
@bbpennel bbpennel changed the title WIP: BXC-4648 - Don't create empty SIPs BXC-4648 - Don't create empty SIPs Jul 24, 2024
@bbpennel bbpennel changed the title BXC-4648 - Don't create empty SIPs WIP: BXC-4648 - Don't create empty SIPs Jul 24, 2024
…db directory is no longer in the SIP directory so doesn't cause cleanup problems
@bbpennel bbpennel changed the title WIP: BXC-4648 - Don't create empty SIPs BXC-4648 - Don't create empty SIPs Jul 25, 2024
@krwong krwong merged commit e3616e2 into main Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants