BXC-4630 derivative MP3 from WAV #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
requested changes
Aug 22, 2024
...s-camel-app/src/main/java/edu/unc/lib/boxc/services/camel/audio/AudioEnhancementsRouter.java
Show resolved
Hide resolved
...s-camel-app/src/main/java/edu/unc/lib/boxc/services/camel/audio/AudioEnhancementsRouter.java
Outdated
Show resolved
Hide resolved
...s-camel-app/src/main/java/edu/unc/lib/boxc/services/camel/audio/AudioEnhancementsRouter.java
Outdated
Show resolved
Hide resolved
...s-camel-app/src/main/java/edu/unc/lib/boxc/services/camel/audio/AudioEnhancementsRouter.java
Outdated
Show resolved
Hide resolved
...c/main/java/edu/unc/lib/boxc/services/camel/destroyDerivatives/DestroyDerivativesRouter.java
Outdated
Show resolved
Hide resolved
...test/java/edu/unc/lib/boxc/services/camel/destroyDerivatives/DestroyDerivativesRouterIT.java
Show resolved
Hide resolved
...amel-app/src/test/java/edu/unc/lib/boxc/services/camel/enhancements/EnhancementRouterIT.java
Outdated
Show resolved
Hide resolved
| @@ -51,7 +51,8 @@ public List<ContentObjectRecord> listViewableFiles(PID pid, AccessGroupSet princ | |||
| ContentObjectRecord briefObj = solrSearchService.getObjectById(new SimpleIdRequest(pid, principals)); | |||
| String resourceType = briefObj.getResourceType(); | |||
| if (ResourceType.File.nameEquals(resourceType)) { | |||
| if (briefObj.getDatastreamObject(DatastreamType.JP2_ACCESS_COPY.getId()) != null) { | |||
| if (briefObj.getDatastreamObject(DatastreamType.JP2_ACCESS_COPY.getId()) != null | |||
| || briefObj.getDatastreamObject(DatastreamType.AUDIO_ACCESS_COPY.getId()) != null) { | |||
There was a problem hiding this comment.
I'm not totally sure what the impact of this is going to be until we test it, just making a note to remember to check back in on it
...mel-app/src/test/java/edu/unc/lib/boxc/services/camel/audio/AudioEnhancementsRouterTest.java
Outdated
Show resolved
Hide resolved
…ts/test/assertions, use FcrepoJmsConstants, update context file
bbpennel
requested changes
Aug 23, 2024
...amel-app/src/test/java/edu/unc/lib/boxc/services/camel/enhancements/EnhancementRouterIT.java
Outdated
Show resolved
Hide resolved
...-camel-app/src/main/java/edu/unc/lib/boxc/services/camel/audio/AudioDerivativeProcessor.java
Outdated
Show resolved
Hide resolved
…est, update context files
bbpennel
approved these changes
Sep 6, 2024
krwong
added a commit
that referenced
this pull request
Oct 25, 2024
* BXC-4630 derivative MP3 from WAV (#1789) * generate mp3 derivatives from wav files * generate mp3 derivatives from wav files * fix destroy derivative and enhancement tests * fix javadoc, unique startuporder value and route id, add log statements/test/assertions, use FcrepoJmsConstants, update context file * remove constructor, rename bean to addAudioAccessCopyProcessor, add test, update context files * rename bean addAudioAccessCopyProcessor in context file * add audio/wave and audio/x-wave to mimetypes * switch mp3 to m4a * add audioDerivativeProcessor to service-context * change audio temp path from -access to -audio * add audio mimetypes to pattern (#1798) * use m4a derivates for access * fix test * add audio access datastream to isAudio, setSoundContent, and IIIFv3ViewableFilter * soundContent conditional, add contentObject id to getAccessPath, fix audioDs resolution * use cover viewer if audio access datastream present * remove changes to FullRecordController, add audio datastream to hasViewableFiles and performQuery * fix test * add audio derivative to DerivativeServiceTest * Code climate --------- Co-authored-by: krwong <[email protected]> Co-authored-by: krwong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-4630
AUDIO_ACCESS_COPYtoDatastreamTypeandDatastreamPermissionUtilAudioDerivativesProcessorandAudioEnhancementRouterto services-camel-appDestroyDerivativesRouteraudioAccessCopytodefaultEnhancementsinEnhancementRouterCdrAudioPathtoCdrFcrepoHeaders