Update onTextChanged in MonacoEditorReactComp

[vrama628]

Fixes #683

Updates MonacoEditorReactComp to correctly handle changes to the onTextChanged prop.

Note: since there isn't a test suite for the React component on main, this branch includes changes from both this PR and #681 . See here for a diff of just the changes relevant to this PR.

The first commit adds a test case that reproduces the issue, and the second commit fixes it. When I run the test after the fix, Vite seems to get stuck and infinitely hang; I wasn't able to figure out why. I'm open to suggestions on how to fix the test case to run properly in vitest, or I can just remove the test case altogether.

[kaisalmen]

Hi @vrama628 let's merge #682 first, then you can rebase this PR. I will try to understand why the test fails and see if there is a solution or workaround.

[vrama628]

Thanks, I'll convert this to a draft until #682 merges and I rebase this

[kaisalmen]

@vrama628 I just squash merged #682

[vrama628]

@kaisalmen thanks, I've rebased and marked as ready for review

[kaisalmen]

@vrama628 interesting, the test only fails on Linux, but not on Windows. @CGNonofr looking at the error message do you have a spontaneous idea (we are not on v6, yet btw)?

[CGNonofr]

@vrama628 interesting, the test only fails on Linux, but not on Windows. @CGNonofr looking at the error message do you have a spontaneous idea (we are not on v6, yet btw)?

Those unable to load extension-file:///... errors are hard to debug because VSCode hides the actual file it's trying to load. There is a fetch that is failing somewhere, you need to find it

[kaisalmen]

@CGNonofr thank you. I guessed that I have to debug it, but there was a small chance you had an idea. Updating to the newest version did not change the behaviour, btw

[CGNonofr]

@CGNonofr thank you. I guessed that I have to debug it, but there was a small chance you had an idea. Updating to the newest version did not change the behaviour, btw

Is this a jest test or something? did you override the fetch behavior?

[kaisalmen]

Is this a jest test or something? did you override the fetch behavior?

It is vitest in headless browser mode using chrome via webdriver.io

[CGNonofr]

Is this a jest test or something? did you override the fetch behavior?

It is vitest in headless browser mode using chrome via webdriver.io

Ok, I'm not familiar at all with it, I won't be able to help any further, sorry

[vrama628]

It looks like updateExtendedAppPrototyp from the monaco-editor-wrapper test suite is designed to deal with this exact issue in tests -- could that help here? I think I tried that but then ran into a different issue where vite would hang

[kaisalmen]

@vrama628 that is exactly the issue. I didn't see that yesterday. I will merge this now and post a fix on main.

[kaisalmen]

LGTM. Test will be fixed on main

[kaisalmen]

Build pipeline is green again: https://github.com/TypeFox/monaco-languageclient/actions/runs/9702661785

[kaisalmen]

@vrama628 new release are available:
https://www.npmjs.com/package/monaco-languageclient/v/8.6.0
https://www.npmjs.com/package/monaco-editor-wrapper/v/5.3.0
https://www.npmjs.com/package/@typefox/monaco-editor-react/v/4.3.0