Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Chat
type is defined to have aVec<BoxedChat>
as a member (indirectly, throughBaseChatComponent
type) because originally I thought the indirection was necessary inVec
type. As it turns out, I didn't know Rust all that well when I wrote this code, and I realize now that we don't need the indirection in this case.I left the
BoxedChat
alias and the.boxed()
method on theChat
type because indirection is required in one case (the only associated value forChatHoverEvent::ShowText
must be aChat
type).Review Notes: