Widen Optimization compat to v4, and related packages accordingly #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2327 +/- ##
===========================================
- Coverage 86.80% 57.43% -29.38%
===========================================
Files 24 24
Lines 1599 1588 -11
===========================================
- Hits 1388 912 -476
- Misses 211 676 +465 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10990803250Details
💛 - Coveralls |
torfjelde
approved these changes
Sep 23, 2024
|
merging so that compathelper doesn't reopen the same prs again |
|
The tests seemed to be failing. Did we understand why? |
|
Seems to be upstream method ambiguities JuliaDiff/ForwardDiff.jl#681 |
|
Will revert |
penelopeysm
added a commit
that referenced
this pull request
Sep 25, 2024
)" This reverts commit 1c98784.
penelopeysm
added a commit
that referenced
this pull request
Sep 27, 2024
penelopeysm
added a commit
that referenced
this pull request
Oct 24, 2024
* Reapply "Bump Optimization to v4, and related packages accordingly (#2327)" (#2343) This reverts commit 3c91eec. * Unmark Mooncake as broken on Optimization v4 --------- Co-authored-by: Markus Hauru <[email protected]> Co-authored-by: Hong Ge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes a bunch of CompatHelper PRs that did this bit-by-bit.