-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Sampling context as not needing derivatives #556
Conversation
Is it possible to add a simple test for this change? Generally, it might also be a good candidate for an extension. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 80.24% 80.26% +0.01%
==========================================
Files 25 26 +1
Lines 3159 3167 +8
==========================================
+ Hits 2535 2542 +7
- Misses 624 625 +1 ☔ View full report in Codecov by Sentry. |
I'm happy with the changes but perhaps convert this to an extension |
So the only dependency here is our interface package EnzymeCore, rather than the fully heavyweight Enzyme. Extension is fine, but this is similar to how ChainRulesCore is currently used within this package already. |
@devmotion done |
There are a few dependencies that were added before support for weak dependencies was available and should be made weak dependencies (e.g. Test #550, ChainRulesCore, and ZygoteRules). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments:)
Thanks @wsmoses @devmotion @torfjelde! |
No description provided.