Upgrade typescript, prettier, et al to continue to modernise build environment #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey both need to be done for any code changes). Fix some no-op type definitions i.e. X extends any, and enforce templated property types as having to extend GeoJsonProperties throughout.
… = GeoJsonProperties problem in geojson-rbush. Also fix a couple of floating point precision related issues that eslint now apparently catches!
…ve changed) to avoid widespread, minor formatting changes (trailing commas mostly).
twelch
approved these changes
Oct 22, 2023
| "@types/node": "^17.0.21", | ||
| "@typescript-eslint/eslint-plugin": "^4.8.0", | ||
| "@typescript-eslint/parser": "^4.8.0", | ||
| "@types/node": "18.11.9", |
There was a problem hiding this comment.
Is the intention to lock the version for this particular dependency? Just curious.
There was a problem hiding this comment.
Ran in to problems straying too far from this version. For example at time of committing 18.18.6 falls over. Could maybe loosen to patch ~ level updates, though want to understand more how the relationship works between this and whatever depends on it first.
|
Thanks for taking a look @twelch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading typescript, prettier and a couple of other development libraries. Aims to modernise build environment. Tried to keep actual business logic code changes to a minimum. Largely succeeded as most changes are punctuation, or in a few cases tightening of type definitions.
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Submitting a new TurfJS Module.
n/a