Replace ts-node with tsx in doc and test related build scripts #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TS runtime. Will run MRL --fix and commit per-package changes next.
…doc, and test:tape. Hand edited last-checks scripts in packages/turf/
mfedderly
approved these changes
Sep 10, 2023
smallsaucepan
added a commit
to smallsaucepan/turf
that referenced
this pull request
Sep 14, 2023
…meaning we can use import rather than require. Tightened up distance module function names and their optional parameters as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces ts-node with tsx in doc generation and test scripts wherever possible to allow us more flexible use of third party libraries.
Background: as part of working on issue #1726 and associated PR #2476 I ran in to some problems where ts-node fell over trying to run the turf unit tests. A third party library we would like to use introduced import mechanisms that ts-node wasn't coping with when running tests. This seems to be related to mixing CJS / ESM imports.
Note that the turf library itself was building fine - just the tests were failing.
Once this PR is merged it will clear the way for PR #2476 to progress.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Submitting a new TurfJS Module.
n/a