-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@turf/boolean-contains): Add MultiPolygon support #2338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thanks @Debakel - I'm just waiting for CI to pass before merging. And the team is hoping that we'll get a release out soon
@rowanwins hi! When is this going to be released? |
Hi @antonmelbardis - this should now be available in 7.0.0-alpha.0 which is available on npm |
@rowanwins thank you sir! |
fyi- still getting |
@rowanwins @nick-romano yeah, the issue is still there unfortunately |
@antonmelbardis @nick-romano The PR implemented ➡️ It's only possible to check wether a Polygon is contained by a MultiPolygon and not vice-versa. |
I'm looking for point(MultiPolygon, Point), but maybe there's another way to accomplish that. Found it! booleanPointInPolygon(). This function could be worth a mention from the booleanContains() docs. |
Adds support for MultiPolygons to
booleanContains()
.Closes #2337
Please fill in this template.
npm test
at the sub modules where changes have occurred.npm run lint
to ensure code style at the turf module level.