Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feedback.js #2676

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

guaka
Copy link
Contributor

@guaka guaka commented Feb 20, 2024

"Leave your public feedback here. Remember to be respectful of others and restrain from any kind of abusive behaviour."

#2539

Proposed Changes

Testing Instructions

Fixes #

"Leave your public feedback here. Remember to be respectful of others and restrain from any kind of abusive behaviour."

#2539
@guaka guaka linked an issue Feb 20, 2024 that may be closed by this pull request
@chmac
Copy link
Member

chmac commented Feb 20, 2024

The failure seems to be caused by this:

"leaflet-active-area": "git+https://github.com/Mappy/Leaflet-active-area.git#f09574a3eb7fdce3a6778e4822955c6416415e43",

But the error complains about:

npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://[email protected]/Mappy/Leaflet-active-area.git
npm ERR! 
npm ERR! [email protected]: Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.

Which suggests it's connecting over ssh and failing. But why it's failing is unclear. It seems like it ran successfully in the past. On our side, nothing should have changed. That repo still exists, the commit still exists.

@chmac
Copy link
Member

chmac commented Feb 20, 2024

Blocked by #2680

@chmac chmac removed the blocked label Feb 20, 2024
@chmac
Copy link
Member

chmac commented Feb 20, 2024

Now we see failures because your changes actually fail to lint properly @guaka!

@chmac chmac merged commit 3e94ead into master Feb 20, 2024
2 of 4 checks passed
@chmac chmac deleted the 2539-add-info-about-respect-when-writing-an-experience branch February 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info about "respect" when writing an experience
2 participants