change some links to https from http #2647
Conversation
chagai95
requested review from
mrkvon,
guaka,
rastapasta,
hlibbabii,
robokow,
sitarane and
rumwerfer
There was a problem hiding this comment.
Great step improving users' privacy!
Linter failed because of prettier. You can fix that with
npm run lint -- --fixSome links only show meaningful content when using http. So it would be good either to keep the http, or (in case of redirect) to use the redirected link. I added notes when i noticed this. (marked with ⬇️)
Some links are dead or dysfunctional. I added notes where i noticed it, but it's out of scope of this PR to fix those. Feel free to ignore those comments, they're just for future reference or something... 😉 (marked with 👌🏾)
I'll be happy to approve when linter passes and when the links which only work with http get reverted or otherwise fixed... 👍🏾
edit: i also added suggestion how to fix the failing test
| @@ -134,7 +134,7 @@ export default function FaqFoundation() { | |||
| <a href="/contribute">Donations</a> and grants are the most likely | |||
| ways. There are many inspiring organisations out there serving as | |||
| great examples:{' '} | |||
| <a href="http://www.abgefahren-ev.de/">Abgefahren e.V.</a>{' '} | |||
| <a href="https://www.abgefahren-ev.de/">Abgefahren e.V.</a>{' '} | |||
There was a problem hiding this comment.
⬇️ This one doesn't seem to have https version. Only http.
| @@ -7,51 +7,51 @@ Font license info | |||
|
|
|||
| Author: Dave Gandy | |||
| License: SIL () | |||
| Homepage: http://fortawesome.github.com/Font-Awesome/ | |||
| Homepage: https://fortawesome.github.com/Font-Awesome/ | |||
There was a problem hiding this comment.
👌🏾 This one doesn't exist anymore, but i'm not sure what would be a proper link. 🤷🏾♀️
| License: SIL (http://scripts.sil.org/OFL) | ||
| Homepage: http://aristeides.com/ | ||
| License: SIL (https://scripts.sil.org/OFL) | ||
| Homepage: https://aristeides.com/ |
There was a problem hiding this comment.
⬇️ https page has error, and http redirects to https://aristath.github.io/, so maybe that's the proper link?
Anyways, it would make sense to either keep the http, or use the new https link
| @@ -124,7 +124,7 @@ export default function Foundation({ user }) { | |||
| <Trans t={t} ns="pages"> | |||
| Working on big freegan/travel projects such as{' '} | |||
| <a href="https://hitchwiki.org/">Hitchwiki</a>,{' '} | |||
| <a href="http://hitchgathering.org/"> | |||
| <a href="https://hitchgathering.org/"> | |||
There was a problem hiding this comment.
⬇️ The https version hangs for me. Only the http version seems to redirect to a meaningful page
| @@ -60,7 +60,7 @@ <h1>We’ll be back soon!</h1> | |||
| <br> | |||
| <p>Follow us on <a href="https://twitter.com/trustroots">Twitter</a> and <a href="https://www.facebook.com/trustroots.org">Facebook</a></p> | |||
| <br> | |||
| <p>Check our <a href="http://status.trustroots.org/">status page</a></p> | |||
| <p>Check our <a href="https://status.trustroots.org/">status page</a></p> | |||
There was a problem hiding this comment.
👌🏾 This one doesn't seem to function properly. In any case https is better than http. Review and fixing of links can be done in separate PR.
| @@ -42,7 +42,7 @@ export default function FaqTechnology() { | |||
| limited software you can imagine that still works for hospitality. We | |||
| simply haven't had time to build most of the features yet. Please | |||
| be patient and be mindful about{' '} | |||
| <a href="http://www.productstrategymeanssayingno.com/"> | |||
| <a href="https://www.productstrategymeanssayingno.com/"> | |||
There was a problem hiding this comment.
⬇️ The https version hangs for me at the moment. Only the http link redirects to a meaningful website atm.
| @@ -380,7 +380,7 @@ describe('Message CRUD tests', function () { | |||
| '<br />blockquote' + | |||
| '<p>' + | |||
| '<a href="https://www.trustroots.org/">link</a>' + | |||
| '<a href="http://www.trustroots.org">www.trustroots.org</a>' + | |||
| '<a href="https://www.trustroots.org">www.trustroots.org</a>' + | |||
There was a problem hiding this comment.
This test fails: the original link www.trustroots.org actually formats to <a href="http://www.trustroots.org">www.trustroots.org</a>
(to http)
So this change should be reverted, in order for tests to pass again.
Proposed Changes
Testing Instructions
Fixes #