Add scope to default application credentials #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using application default credentials with Workflow Identity Federation, the API call to GCP fails with "Request had insufficient authentication scopes.". This attempts to fix that by setting the scope in the GoogleCredentials object.
|
cc @a-mackay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the capability to authenticate with application default credentials.
When the application default credentials are generated using workload identity federation like in a Github action, the generated JSON doesn't contain
scopes. As a result, the google-auth-library defaults to a scope ofhttps://www.googleapis.com/auth/cloud-platform, which doesn't include the androidpublisher scope.To support all forms of application default credentials (including Identity Pool Credentials), we should specify a scope. Some more info about this is also in googleapis/google-auth-library-java#1274.