Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove yarn engine requirement #29

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

rickdgeerling
Copy link
Collaborator

It should work with all versions of Yarn, this prevents users of classic Yarn from consuming the package.

It should work with all versions of Yarn, this prevents users of classic
Yarn from consuming the package.
Copy link
Contributor

@tolgap tolgap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

If we change this, shouldn't we also lower the runtime node version requirement to 16? NestJS still supports Node 16.

Aligns with NestJS core
@rickdgeerling
Copy link
Collaborator Author

@tolgap Yeah agreed

Copy link
Contributor

@thiagomini thiagomini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagomini thiagomini merged commit 8fe314e into main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants