Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding failing test for Issue #272 #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevindugan
Copy link
Contributor

This PR adds regression tests for Issue #272. These tests fail without the changes implemented in PR #273 and pass when those changes are applied.

@kevindugan
Copy link
Contributor Author

@bartlettroscoe I placed these tests in the User Error Package, but would it be better to create a new 'PkgRegressions' package? I didn't want to change the structure too much for these tests, but I'll admit it seems a little strange to put valid package declarations in something testing for user errors.

@bartlettroscoe
Copy link
Member

@kevindugan, does this PR fix the usage of TriBITS by VERA?

@kevindugan
Copy link
Contributor Author

@bartlettroscoe This PR only addresses the testing of the changes I made in the previous PR (#273). I still need to find a solution to the VERA/MOOSE problem I'm having.

On a related issue, we're seeing debug/optimized tags leaking into the libraries we're linking to. I've found where these tags are added for certain libraries (HDF5, I think). Is it possible that these tags aren't getting removed from another library, Qt maybe?

@bartlettroscoe
Copy link
Member

This PR only addresses the testing of the changes I made in the previous PR (#273). I still need to find a solution to the VERA/MOOSE problem I'm having.

@kevindugan, okay, then lets address the real problem in getting VERA to work. In issue #272, can you please attach the full CMakeLists.txt file where this error is triggered and then attach the full configure output? Otherwise, I will need to get back my access to ORNL so that I can see what is happening myself. Let's discuss in issue #272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants