Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# VALIDATE sample names issue in Snakefile #69

Open
DenisTEMPE opened this issue Mar 11, 2020 · 3 comments
Open

# VALIDATE sample names issue in Snakefile #69

DenisTEMPE opened this issue Mar 11, 2020 · 3 comments

Comments

@DenisTEMPE
Copy link

The "VALIDATE sample names" command line in the Snakefile allows letters, underscore and numbers from 1 to 9, thus excluding 0-containing file names :
if not re.match(r"^[a-zA-Z][1-9a-zA-Z_]$", name):
I replaced it by the following:
if not re.match(r"^[a-zA-Z][0-9a-zA-Z_]
$", name):
And it now works fine.

@DenisTEMPE
Copy link
Author

Sorry I didn't get the 1.3.4 release fixing this issue one year ag!...
Merci Jérôme

@jaudoux
Copy link
Collaborator

jaudoux commented Mar 11, 2020

@DenisTEMPE Great ! I forgot about that, I was going to fix it another time...

How did it happened that you did not had the latest version? Did U used Docker, Conda, Singluarity or a manual install ?

Do no hesitate to submit other issues if you have other bug or questions about DEkupl.

Best,
J.

@DenisTEMPE
Copy link
Author

Hi Jérôme,
It seems that the Conda version of dekupl-run is still not up to date.
Could the Conda release be updated to the latest version?
Thanks in advance!
Denis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants