Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add action control flow, workflow static inputs and workflow return value expression #261

Merged
merged 16 commits into from
Jul 23, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Jul 23, 2024

Features

  • Add control flow editor
    • Run if
    • Loop
  • Add workflow return value expression editor. We need this for child workflows to return values to the parents
  • Add workflow static inputs editor
  • Add tooltips and usage examples for each
  • Create custom editor component with upgraded editor styles
  • Update api to handle the able use cases

Changes

  • Changed action node copy jsonpath to copy action reference which will copy ACTIONS.<node slug>

Testing

  • Manual QA with child workflows. Also tested running child workflows with schedules.
  • Found some edge cases when parsing the workflow return value fails, which triggers infinite retry. Urgently needs to be fixed

Screens

Screenshot 2024-07-23 at 15 25 53 Screenshot 2024-07-23 at 15 25 41 Screenshot 2024-07-23 at 15 25 31

@github-actions github-actions bot added enhancement New feature or request frontend Improvements or additions to the frontend labels Jul 23, 2024
@daryllimyt daryllimyt changed the title feat(ui): Add control flow and return value expression feat(ui): Add action control flow, workflow static inputs and workflow return value expression Jul 23, 2024
@daryllimyt daryllimyt self-assigned this Jul 23, 2024
Copy link
Contributor

@topher-lo topher-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topher-lo topher-lo merged commit bc8c29f into main Jul 23, 2024
9 checks passed
@topher-lo topher-lo deleted the feat/add-control-flow-and-returns branch July 23, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Improvements or additions to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants