Add docker support (closes #147) #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...I've been naughty ;)
I set up the docker branch as PR to show that the support is trouble-free and not very complex. The maintenance of these four files should only require a small effort in future releases.
I think the added value is very high and supports future CI/CD pipelines for automatic testing. Adjustments can be made by the user in the `.env' file. Updates regarding new versions of the services can be made by the contributors in the docker-compose.yml. However, this should be limited to changing the version numbers.
For further details I also have a version of the README, which explains the containers and the variables in detail. But in the current state the extension works without any adjustment.
Despite your answer I suggest the files in the hope to convince you to put the Docker support back to the upstream. If it still seems too complex, do whatever you want with them ;)
(in reference to #147)