Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vendor id definition for purchases #125

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

jasanchez1
Copy link
Contributor

Adds the optional vendor id definition for purchases to our docs

@jasanchez1 jasanchez1 requested a review from sk- June 19, 2024 14:00
@@ -1141,6 +1142,11 @@ components:
exclusiveMinimum: true
description: The price of a single item in the marketplace currency.
example: 12.95
vendorId:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to explain when to add vendorId.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we probably should mention that this is generally optional and it is required in case they have multiple providers or when they want to use halo attribution.

Copy link
Contributor Author

@jasanchez1 jasanchez1 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed just added that

@jasanchez1 jasanchez1 enabled auto-merge (squash) June 19, 2024 14:39
@jasanchez1 jasanchez1 merged commit e132ed4 into main Jun 19, 2024
1 check passed
@jasanchez1 jasanchez1 deleted the docs/juaco/purchases_vendor_id branch June 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants