Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Transform] Remove can't find field exception #16

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

xiaochen-zhou
Copy link
Collaborator

Purpose of this pull request

In the FilterFieldTransform, we don't need to use try{} catch to obtain the canNotFoundFields collection, and we can remove the redundant cannotFindInputFieldError logic in the FilterFieldTransform#transformTableSchema().

Does this PR introduce any user-facing change?
no

How was this patch tested?
exist tests.

Check list

@xiaochen-zhou xiaochen-zhou merged commit e8b94a8 into dev Apr 19, 2024
67 of 68 checks passed
@xiaochen-zhou xiaochen-zhou deleted the filter_transform_2 branch May 3, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant