Set up caching to speed up build and test. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetorpedodog
force-pushed
the
build-cache
branch
17 times, most recently
from
49014e8
to
e3aaaac
Compare
thetorpedodog
changed the title
This change unifies the build scripts between Mac OS and Linux, and caches build outputs. This means that future builds of the same version don’t need to rerun the entire build process; they can use the previously-built version. We do a few things to accomplish this: - Move compilation/installation into the `~/tiledb-core/install` directory. This allows us to cache it. - Set appropriate `CGO_*FLAGS` variables to point to that directory. This includes the `rpath` directive, which embeds the full path to the dynamic library in the binary, so it knows it needs to look in `~/tiledb-core/install/lib` for `libtiledb.so`. - Matrixes things out to reduce repetition. This also fixes the ASAN step, which was never actually compiling.
thetorpedodog
force-pushed
the
build-cache
branch
from
e3aaaac
to
1f9718e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change unifies the build scripts between Mac OS and Linux,
and caches build outputs. This means that future builds of the same
version don’t need to rerun the entire build process; they can use the
previously-built version.
We do a few things to accomplish this:
~/tiledb-core/installdirectory. This allows us to cache it.
CGO_*FLAGSvariables to point to that directory.This includes the
rpathdirective, which embeds the full pathto the dynamic library in the binary, so it knows it needs to look in
~/tiledb-core/install/libforlibtiledb.so.This also fixes the ASAN step, which was never actually compiling.