set idle timeout for io client

[abdelaziz-mahdy]

i saw this change was reverted, but when i looked through the code it passes the client settings in the request requestInternalGeneric of rhttp_client so it seems logical to me that this change should work (correct me if i am wrong, i dont have that much knowledge with rust)

related to #27

[Tienisto]

copyWith is creating a new instance, so this line is a noop

[Tienisto]

I've changed it into a noop, not throwing an exception anymore

[abdelaziz-mahdy]

copyWith is creating a new instance, so this line is a noop

cant we just convert the type of the settings variable to non final and update it? that will make the set idle timeout work instead of being ignored? what do you think

[Tienisto]

The settings is immutable because it is stored in Rust. If we make it mutable, then it would be a lot more complicated to keep everything in sync. Also, immutability is clean while Dart's mutable design is quick and dirty.

There is a workaround to make it work regardless.
We can store a mutable timeout class variable specifically for IoCompatibleClient and override the timeout for each request.
Such one-time override is currently not implemented though.

[abdelaziz-mahdy]

Oh so the limitation is from the rust side

I thought the settings class gets sent with every request from the dart side

This is why I went with that approach 😅

Thanks for explaining