Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keep-alive settings #22

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

nicobritos
Copy link
Contributor

@nicobritos nicobritos commented Sep 17, 2024

Add keep alive timeout settings to enable KA on reqwest, both in HTTP1 (normal TCP KA) and in HTTP2 (allowing KA on idle).

Also, deprecates usage of timeout and connectTimeout to move both of those settings to TimeoutSettings, which includes KA settings.

EDIT: This is needed because by default reqwest doesn't use KA by default:

  1. KA on HTTP2 when idle (default is false)
  2. HTTP2 KA ping (default is None)
  3. HTTP2 KA timeout (default is None, disable KA)
  4. KA on HTTP1 (I understand that it's disabled by default)

@Tienisto Tienisto merged commit a7a5521 into Tienisto:main Sep 17, 2024
2 checks passed
@Tienisto
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants