improvement: $:/snippets/peek-stylesheets to use modern tiddlywiki features #8794
Conversation
Replace reveal widget by conditional shortcut syntax, use string substitution, let widget
|
@DesignThinkerer It appears that this is your first contribution to the project, welcome. With apologies for the bureaucracy, please could you prepare a separate PR to the 'tiddlywiki-com' branch with your signature for the Contributor License Agreement (see contributing.md). |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DesignThinkerer
changed the title
| <<stylesheets-list>> | ||
| </$reveal> | ||
| <%if [<mode>match[expand]]%> | ||
| <$transclude $variable="expandable-list" filter=<<listFilter>> open="yes"/> |
There was a problem hiding this comment.
The "open", "closed" state value is wrong. It is expanded and restored
Have a look at the state: https://tiddlywiki.com/#%24%3A%2Fstate%2Fpeek-stylesheets%2Fmode%2F-1116772087 at tiddlywiki.com and at: https://deploy-preview-8794--tiddlywiki-previews.netlify.app/#%24%3A%2Fstate%2Fpeek-stylesheets%2Fmode%2F-1116772087
current Version v5.3.6
PR version
It is not possible to change those values for backwards compatibility reasons. There may be unwanted side effects.
There was a problem hiding this comment.
Understood, sorry for the oversight 😅 I'm marking this PR as a draft for now and will request a review after more thorough testing.
|
DesignThinkerer has signed the Contributor License Agreement (see contributing.md) |
This PR aims to modernise $:/snippets/peek-stylesheets
\procedureinstead of\defineletinstead ofvarsconditional shortcut syntaxinstead ofrevealtemplate parametersfor the iconsstring substitution(backticks)