-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support zotero:// external link #8692
base: master
Are you sure you want to change the base?
Conversation
@zorrox1024 It appears that this is your first contribution to the project, welcome. With apologies for the bureaucracy, please could you prepare a separate PR to the 'tiddlywiki-com' branch with your signature for the Contributor License Agreement (see contributing.md). |
Should we just use |
IMO the regexp can be changed to recognize all url schemes as external links. |
zorrox1024 has signed the Contributor License Agreement (see contributing.md) |
I do not think it should identify There are about 300 official URL schemes and only a hand full of them make sense for TW. @zorrox1024 zotero file scheme is not registered at IANA. So where can we find the specification? |
Thanks @zorrox1024. I think it is reasonable for users to want Zotero links to work within TiddlyWiki. I wonder whether we might take this as an opportunity to refactor the external links mechanism so that plugins can extend it with additional URL schemes specified via configuration tiddlers. The core would then check through a list of external link regexps, and return "true" if any of them match. The implementation would need to be careful to maintain efficiency. |
Actually not all protocols are registered in IANA, the |
I prefer to this solution. I should depends on browser or Desktop OS setting, which schema is supported. for example, i custom a telnet:// scheme to start a telnet terminal to open connect fast |
That's right. But obsidian's spec is easy to find: https://help.obsidian.md/Extending+Obsidian/Obsidian+URI |
Sadly I think there are too many false positives. The following strings all qualify as external URLs with the regexp
|
how about something like
|
I did some research on common URL schemes. For example, here's a list of schemes used by apps on macOS. I think part of the problem is that our current URL regex is too lax. It doesn't require the sequence So, I wonder if we might simplify things by testing explicitly for |
@pmario Desktop app can register anything, like BTW I wanted to add support for
@zorrox1024 This is JS, so you can do anything, feel free, even use 2 regex and |
No description provided.