Fix/lingo germany #8269
Fix/lingo germany #8269
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <$let language-code={{{ [[$:/language]get[text]get[name]else[en-GB]] }}}> | ||
| <$transclude $tiddler={{{ [<active-lingo-base>addsuffix<language-code>addsuffix[/]addsuffix<title>] }}} $mode=<<parseMode>>/> | ||
| <$transclude $tiddler={{{ [<active-lingo-base>addsuffix<language-code>addsuffix[/]addsuffix<title>] }}} $mode=<<parseMode>>> |
There was a problem hiding this comment.
It is 1 level above let, isn't wrong
There was a problem hiding this comment.
Sorry. I always put my comments below the issue. So IMO transclude has the wrong indent.
There was a problem hiding this comment.
I didn't see any wrong in vscode
There was a problem hiding this comment.
Have a look at the file. https://github.com/Jermolene/TiddlyWiki5/blob/e9568720489ae5fe9ee74cd16330b8168028beff/core/wiki/macros/lingo.tid#L20C1-L20C9 Line 20 uses spaces instead of tabs for indentation. If you fix that it should work
|
I can create a dependency tree, that will fall back to English instead of German, which technically would be wrong. -- But -- There is a fallback now. The dependency tree mentioned above is "constructed to fail". It's not very likely to be a real world configuration. |
|
@Jermolene -- This is a fix, that needs to go into v5.3.4, since it would be a general regression. This PR is related to: menu-bar German translation first take #8264 |
|
I will write a JS version later. I was also afraid that so many transluction widget will be slow. |
|
hmmm, I do not really see a performance problem, for UI elements, which most of the translations are. "Inner" transclusions are only executed, if they do not return anything. So the transclusion-widget returns early. All the filters strings are "compiled" into js-functions and cached internally.
Edit: OK I did see the conversation starting at: #7821 (comment) --- So forget about that question |
fixes #8263 fixes #8262 @pmario