Merge pull request #70 from cyber-person/superfluous_error_handling

superfluous error handling removed
Threagile · May 14, 2024 · f138f47 · f138f47
2 parents 63f6f3b + ef2b645
commit f138f47
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/pkg/model/parse.go b/pkg/model/parse.go
@@ -186,9 +186,6 @@ func ParseModel(config *common.Config, modelInput *input.Model, builtinRiskRules
 			technicalAssetTechnologies = append(technicalAssetTechnologies, technicalAssetTechnology)
 		}
 
-		if err != nil {
-			return nil, fmt.Errorf("unknown 'technology' value of technical asset %q: %v", title, asset.Technology)
-		}
 		encryption, err := types.ParseEncryptionStyle(asset.Encryption)
 		if err != nil {
 			return nil, fmt.Errorf("unknown 'encryption' value of technical asset %q: %v", title, asset.Encryption)
@@ -286,9 +283,6 @@ func ParseModel(config *common.Config, modelInput *input.Model, builtinRiskRules
 				}
 
 				dataFlowTitle := fmt.Sprintf("%v", commLinkTitle)
-				if err != nil {
-					return nil, err
-				}
 				commLinkId, err := createDataFlowId(id, dataFlowTitle)
 				if err != nil {
 					return nil, err

diff --git a/pkg/script/script.go b/pkg/script/script.go
@@ -298,7 +298,7 @@ func (what *Script) generateRisk(outerScope *common.Scope, techAsset any) (*type
 		}
 
 		newValue, errorEvalLiteral, evalError := expression.EvalAny(scope)
-		if parseError != nil {
+		if evalError != nil {
 			return nil, errorEvalLiteral, fmt.Errorf("failed to eval field value: %v", evalError)
 		}