tests: fix broken tests #1120
Closed
tests: fix broken tests #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyaZar
force-pushed
the
fix-1119-broken_tests_for_with_opt
branch
from
f98ba87
to
c78499d
Compare
|
Note to self : have to look into this bcs I think running load_all() inside the tests themselves might have some weird side effects 🤔 Do we do this already? |
|
Hey, Thanks for working on this. I've worked on a full refactoring of the test suite, so this won't be needed anymore :) The two main goals of the test refactoring has been :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for
tests/testthat/test-with_opt.Rbut improves codecov forR/with_opt.Rfrom 9.68% to 100% and overall package covr a bit.Fix #1119