Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to upgrade schema to Json 2020-12 #833

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

peter-quandify
Copy link
Contributor

Summary

The schema.json and lib/payload.jsonuses JSON schema draft 07.
This PR is a proposal to upgrade it to draft 2020-12.

Changes

  • Updated schema.json to draft 2020-12 format
  • Updated lib/payload.json to draft 2020-12 format
  • Updated bin/validate.js
    • Ajv 6.x -> 8.x that support 2020-12 format
    • Ajv compile -> getSchema
    • Ajv breaking change dataPath -> instancePath
  • Clean-up of unused dependencies
  • Upgraded Ajv cli and applied security patch

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

The upgrade to JSON schema draft 2020-12 made all thermokon productUrl invalid, which needs to fixed before merge.

Release Notes

Upgraded JSON schema for validation to draft 2020-12

@johanstokking
Copy link
Member

@peter-quandify thanks a lot. You can append 7ed71bd here; I don't have permissions to push to your branch.

@johanstokking johanstokking self-assigned this Oct 14, 2024
@peter-quandify
Copy link
Contributor Author

@johanstokking Done!
But who should report the licens/cla ?

@johanstokking
Copy link
Member

@johanstokking Done! But who should report the licens/cla ?

That would be everyone in the commit trail based on email address, so p*.e*@quandify.com. Do you have a GitHub account associated with that?

@peter-quandify
Copy link
Contributor Author

peter-quandify commented Oct 14, 2024

I have already signed the CLA a while ago on that email, so I'm not sure why it says that

@peter-quandify
Copy link
Contributor Author

Or you could merge your branch @johanstokking and delete this PR?

@johanstokking johanstokking merged commit 584ec7f into TheThingsNetwork:master Oct 14, 2024
1 check passed
@johanstokking
Copy link
Member

I have already signed the CLA a while ago on that email, so I'm not sure why it says that

Let's not bother then!

Thanks again!

@peter-quandify peter-quandify deleted the json-2020-12 branch October 31, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants