Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mysqlclient #955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jangrewe
Copy link

No description provided.

@kennethjiang
Copy link
Contributor

I don't think you did it right. master branch shouldn't have bundled assets. Please fix it or open a new one.

@jangrewe
Copy link
Author

yea, just fighting with a) Github's UI (i'm more of a GitLab guy), and b) that your default branch is release, which i based it off of, instead of master, which is your actual default branch. Disregard for now, i'll work around your style.

@kennethjiang
Copy link
Contributor

yea, just fighting with a) Github's UI (i'm more of a GitLab guy), and b) that your default branch is release, which i based it off of, instead of master, which is your actual default branch. Disregard for now, i'll work around your style.

Thank you! :)

@jangrewe
Copy link
Author

jangrewe commented May 20, 2024

okay, reset it to your master, now it's cleaned up.

But see #954 (comment), which may make this not immediately usable.

@kennethjiang
Copy link
Contributor

Thanks @jangrewe Not sure if I can merge the PR this way, since as you have noted, mysql actually will fail. Can you figure out what's causing the problem and fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants