README.md: sample configuration toggle_telescope fix #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipairs doesn't iterate over all the keys in table. It stops when it sees a nil. If we remove any file in the harpoon:list() we set it to nil. The harpoon's quick_menu ui shows blank for the removed file, however the telescope ui only lists file till it encounters a nil. This same issue might be causing the marked files to disappear on reopening nvim?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipairs doesn't iterate over all the keys in table. It stops when it sees the first nil (removed file).
If we remove any file in the harpoon:list() we set it to nil. The harpoon's quick_menu ui shows blank for the removed file, however the toggle_telescope ui only lists file till it encounters a nil (discards any items in harpoon_files after some nil).