fix(encode): use a for-loop, instead of next() or ipairs(), to prevent loss of data
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue, when there's an empty line inside the quick-menu, which causes everything after the blank line to be forgotten.
For `next()`, the order in which the indices are enumerated is not specified[1], even for numeric indices. Even though it seemed to work, now the encode-/decode-logic uses a numerical `for`-loop, which should keep the order and not miss any items after a `nil`-item. Also, the loop inside the `encode`-function, uses the `list._length` instead of `#items`; which seems to ignore data, when there're 2 or more `nil`-values!? [1] https://www.lua.org/manual/5.1/manual.html#pdf-next
kimabrandt-flx
changed the title
next() instead of ipairs(), to prevent loss of datafor-loop, instead of next() or ipairs(), to prevent loss of data
|
There still seems to be an issue, when there are many blank items!? Some of them are just removed!? But, non-nil items seem to get restored alright!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue, when there's an empty line inside the quick-menu, which causes everything after the blank line to be forgotten (after Neovim is restarted).
This also restores the blank lines, which I'm not certain of is expected or not?!