Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sometimes the statuscolumn disappears. Issue #559 #560

Open
wants to merge 1 commit into
base: harpoon2
Choose a base branch
from

Conversation

abeldekat
Copy link

See issue 559

@ThePrimeagen
Copy link
Owner

any details on this? i am confused what the error is and what you are looking for

@abeldekat
Copy link
Author

abeldekat commented Apr 9, 2024

All details plus a reproducible init are in the related issue.
In the first video, at 0:15, you can observe that the statuscolumn is not present anymore: All line-numbers disappeared.

This happens quite regularly when using Harpoon2. It took some effort to find an exact scenario that is reproducible.

@dwtong
Copy link

dwtong commented Apr 18, 2024

EDIT: i was on neovim v0.9.5 and having this issue, updating to v0.10.0-dev fixed it.

@ThePrimeagen i am also having the same issue (i.e. i cannot see my line numbers aka status column) but it happens to me every time i close and reopen neovim and then jump to a harpoon mark.

opening the same file without harpoon does not have this issue.

this PR solves it for me (see attached clip, where i make the same change as this PR, and it fixes it)

harpoon-statuscolumn.mp4

@abeldekat
Copy link
Author

abeldekat commented Apr 18, 2024

Hello @dwtong,

Thanks for the confirmation!

but it happens to me every time i close and reopen neovim and then jump to a harpoon mark.

If I am not mistaken, you essentially use the same steps I describe in issue #559 :

  1. Open init.lua: repro init.lua
  2. Place the cursor on line 52, requiring Harpoon
  3. Harpoon add
  4. Close Neovim
  5. Open Neovim without arguments: repro
  6. Harpoon select 1 (using the keymapping)

In the video, I also see treesitter-context, as expected.
Do you use a starter plugin?

@dwtong
Copy link

dwtong commented Apr 18, 2024

@abeldekat happy to help. yea, my steps were basically the same, also commenting out the line that you removed in this PR to demonstrate the fix.

my config is based on kickstart but is basically hand rolled at this point.

which version of neovim are you on? i was previously on v0.9.5, but then updated to v0.10.0-dev and it fixed this issue for me.

@abeldekat
Copy link
Author

I use both 0.9.5 and nightly via "bob", and the issue is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants