Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.3 #53

Merged
merged 23 commits into from
Dec 27, 2024
Merged

V2.3 #53

merged 23 commits into from
Dec 27, 2024

Conversation

TheMariday
Copy link
Owner

@TheMariday TheMariday commented Dec 24, 2024

Mari Map-mas everyone!

New features that people asked for!

Improvements that no one asked for!

  • Reconstruction will now happen instantly when opening MariMapper inside a folder with existing scans
  • The detector now chooses the brightest response in the image instead of averaging, should help with reflections
  • Cancelled or failed scans no longer get written to disk

Stuff for the future!

  • The detector is now responsible for iterating through LEDs, easier for development of Fast Mode #38
  • Better typing
  • Better queue handling, hopefully less Hang on exit #49
  • A few more tests

Added framework for movement and sanity checks
Loaded prior detections into sfm on boot
Lots of logging needed, lots of tests, especially the multiprocessing
Added check for darkness before starting scan
removed cancel_join_thread as it //shouldn't// be needed
still need to test if this is an issue and fix
and checking for leds when starting a scan, this needs re-doing but for now it's fine.
removed queue clearing which I might have to deal with later.
Hello pathlib, sorry to not invite you from the start
mypy, you continue to be a rose/thorn in my side
… weird

fixed timeout
bumped logging to warning
did some sanity checking on the sfm pipeline
Fixed bug where camera would not reset when detector spotted leds before start
moved get_overlap_and_percentage to correct location
added a few more tests
@TheMariday
Copy link
Owner Author

TheMariday commented Dec 24, 2024

Hi hi @JimmyBlunt @tschundler,

You've both shown an interest in beta-versions of marimapper, so thought I'd tag you in the latest version I've been working on!

This should also address some of the issues you've been facing.

You should be able to install the development build with the below command if you would like to have a play

pipx install git+https://github.com/TheMariday/[email protected] --force

Mari Map-mas!

<3 Mariday <3

Changed upload_map_to_pixelblaze_cli.py so it defaults to led_map_3d.csv
Removed port in README.md
Added process running checks to the main app so that it can detect if something has crashed or running indefenitely

Added a few more tests to test crashing of multiprocess stuff
@tschundler
Copy link

I should be able to try it out later today or tomorrow.

We'll see how it does with a different camera - I'm not home the rest of this week & next, but I do have LEDs. ;)

@TheMariday TheMariday linked an issue Dec 27, 2024 that may be closed by this pull request
@TheMariday TheMariday merged commit 2d73ec9 into main Dec 27, 2024
10 checks passed
@TheMariday TheMariday deleted the v2.3 branch December 27, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants