-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update eLabFTW examples #72
Conversation
Hi @NicolasCARPi, A few remarks from my side:
|
Hello @jmanideep and thank you for taking the time to review this change.
Fixed.
Done.
Empty values should not appear anymore now.
My mistake. So for
Fixed.
Fixed.
I'd argue that in this context of "extra fields", having no value is still information, and we still want to keep track of the field even if it's empty at the moment of export. |
The import of |
Handling these cases, especially those where |
@FlorianRhiem thank you for trying it out. It was the freshly added Category nodes that were added regardless if an existing one existed already. This is now fixed!
well, |
It now fails due to two comments (the one about the sky being blue and the one about water being wet) both having the same (therefore duplicate) ID. |
@FlorianRhiem thank you, this has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can get it to work now, though there are some issues with the current SampleDB import, as the namelist for that zip file is returned with duplicate path separators, e.g. for ./RD - Testing-relationship-between-acceleration-and-gravity - 5adb0eb3/example.pptx
the namelist lists it as ./RD - Testing-relationship-between-acceleration-and-gravity - 5adb0eb3//example.pptx
so that SampleDB right now reports that file as not found. However the file can be imported successfully if I add a path normalization step, so I'll go with that. SampleDB doesn't import the variablesMeasured
yet, I'm still working on that.
Oh yeah right, the file path of attachements in the ro-crate is different from the name of the file in zip directory! I've fixed that now. |
still a WIP but I wanted to move forward before our meeting tomorrow!