Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate changes discussed in last Nov. meeting #63

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Incorporate changes discussed in last Nov. meeting #63

merged 2 commits into from
Feb 20, 2024

Conversation

SteffenBrinckmann
Copy link
Collaborator

Changed .eln file to correspond to the results of the meeting last Nov.

NicolasCARPi
NicolasCARPi approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@FlorianRhiem
Copy link
Contributor

Works with SampleDB

@jmanideep
Copy link
Contributor

jmanideep commented Feb 19, 2024 •
edited
Loading

Works with Kadi4Mat.

Though we(in Kadi4Mat) are not dealing with the author objects in the ro-crate-metadata.json file, just wondering if there is any particular reason for using list or array type for author objects in your example.

@NicolasCARPi
Copy link
Contributor

Yeah, regarding author, it's best to flatten it: author attributes only points to a node with an @id. This node is of @type: Author.

@SteffenBrinckmann
Copy link
Collaborator Author

Thanks everybody for the feedback.

  • author(s): a paper can have multiple authors, data should be able, too; I guess.
  • great that you can import it; (I am still having issues with some of yours.)
    We can discuss these during our next meeting

@SteffenBrinckmann SteffenBrinckmann merged commit bccc8e4 into TheELNConsortium:master Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasCARPi NicolasCARPi NicolasCARPi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SteffenBrinckmann @FlorianRhiem @jmanideep @NicolasCARPi