Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sensolytics SDC example file #35

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TheRich-71
Copy link

new file:   examples/sensolytics/23-09-20_113808 Experiment.eln
new file:   examples/sensolytics/README.md

	new file:   examples/sensolytics/23-09-20_113808 Experiment.eln
	new file:   examples/sensolytics/README.md
Copy link
Contributor

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a README.md template (example https://github.com/TheELNConsortium/TheELNFileFormat/blob/master/examples/elabftw/README_template.md) so the header stays the same and the content is automatically generated by tools/eln2md.py.

examples/sensolytics/README.md Outdated Show resolved Hide resolved
examples/sensolytics/README.md Outdated Show resolved Hide resolved
"conformsTo": {
"@id": "https://w3id.org/ro/crate/1.1"
},
"dateCreated": "2023-09-20T11:38:09+02:00"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add some metadata about the "Sensolytics GmbH" using sdPublisher property? For example, the following is a sample snippet of how the sdPublisher looks like in Kadi4Mat.

"sdPublisher": {
        "@id": "https://kadi.iam.kit.edu"
      }

And if applicable, also add other properties like name, description, url etc in the sdPublisher node.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is how it looks for elabftw:

      "sdPublisher": {
        "@type": "Organization",
        "name": "eLabFTW",
        "logo": "https://www.elabftw.net/img/elabftw-logo-only.svg",
        "slogan": "A free and open source electronic lab notebook.",
        "url": "https://www.elabftw.net",
        "parentOrganization": {
          "@type": "Organization",
          "name": "Deltablot",
          "logo": "https://www.deltablot.com/img/logos/deltablot.svg",
          "slogan": "Open Source software for research labs.",
          "url": "https://www.deltablot.com"
        }

@NicolasCARPi
Copy link
Contributor

Hello!

Do you want to merge it like this or are you planning to adress the comments made by @jmanideep ?

@TheRich-71
Copy link
Author

We will address the comments most probably next week in a commit...

@NicolasCARPi
Copy link
Contributor

Hello @TheRich-71. We'd love to merge this. Do you think you'll be able to address the comments?

@TheRich-71
Copy link
Author

Yes, certainly, I simply lost track about it. Will address it in our internal meeting next week, and then it should be done soon...

@NicolasCARPi
Copy link
Contributor

I'm currently modifying a lot of ELN related code in eLab, so I'll let others review this, as my app is currently in a work-in-progress state regarding elns.

"sha256": "1ef5b91dd127dc7120262d5c0433bf7afc95e4f188d75aea1c019972f6e67a6b"
},
{
"@id": "./Data/0003_16082,5_17994_CV.nox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a an encodingFormat property maybe? (no idea what is a .nox)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants