Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sum of outcomes for rolling an N-sided dice K times. #11463

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

The sum of outcomes for rolling an N-sided dice K times. #11463

wants to merge 49 commits into from

Conversation

dipuk0506
Copy link

Describe your change:

  • Add an algorithm?

    The sum of outcomes for rolling an N-sided dice K times.

    This function returns a list. The last two elements are the
    range of probability distribution.
    The range is: 'k_time' to 'k_time*n_side'

    Other elements contain probabilities for getting a summation
    from 'k_time' to 'k_time*n_side'.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

dipuk0506 and others added 30 commits June 11, 2024 07:19
@dipuk0506
Create Image_Classification_Example_MNIST_CNN.py
4fd289f 
Image Classification Example
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
29671f5 
for more information, see https://pre-commit.ci
@dipuk0506
Update and rename Image_Classification_Example_MNIST_CNN.py to image_…
4e3484a 
…classification_example_mnist_cnn.py
@dipuk0506
Update image_classification_example_mnist_cnn.py
7b70f64
@dipuk0506
Delete computer_vision/image_classification_example_mnist_cnn.py
a4b7330
@dipuk0506
Create probability_of_n_heads_in_m_tossing.py
158c1fe
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
d8b68ba
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c49619c 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
b62a774
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
707b446 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
df400a7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
929301c 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
b84ac59
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
b79e0c1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
205cb87 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
c987949
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
366f1ff 
for more information, see https://pre-commit.ci
@dipuk0506
Update probability_of_n_heads_in_m_tossing.py
ac01ab0
@dipuk0506
Update and rename probability_of_n_heads_in_m_tossing.py to outcome_o…
e4129b9 
…f_rolling_n_sided_dice_k_time.py
@dipuk0506
Update outcome_of_rolling_n_sided_dice_k_time.py
00e2389
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ce9e835 
for more information, see https://pre-commit.ci
@dipuk0506
Update and rename outcome_of_rolling_n_sided_dice_k_time.py to sum_of…
c7d9ea4 
…_outcomes_for_rolling_n_sided_dice_k_time.py
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d8f511c 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
fcf30bc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
360ef80 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
749499a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7bea0d9 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
164a51d
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b8cb3bc 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
ccf5053
pre-commit-ci bot and others added 19 commits June 14, 2024 12:05
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5d23214 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
592c685
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ea842d6 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
07d07bc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9c51e64 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
1dd86bc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f2d459a 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
1b41f73
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
ca60090
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cedf450 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
fa6c205
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
45f27b7 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
db15528
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
84787b5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1b7eb1d 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
f618200
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
752ed1e 
for more information, see https://pre-commit.ci
@dipuk0506
Update sum_of_outcomes_for_rolling_n_sided_dice_k_time.py
f348aa0
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ea0c141 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jun 15, 2024
@dipuk0506
Copy link
Author

Hi, If you have any confusion about the algorithm, you can email me at [email protected] and arrange a meeting.

@dipuk0506
Copy link
Author

Please email me, if you are confused.

@dipuk0506
Copy link
Author

There are two typos in comments. Everything else seems correct.

Lines 40 and 41 will be as follows:

The probability of getting 2 is 1/36.
The probability of getting 3 is 2/36.

@dipuk0506
Copy link
Author

Please approve

@dipuk0506
Copy link
Author

For theory visit the wiki page:
https://en.wikipedia.org/wiki/Convolution_of_probability_distributions

For more explanation of the theory please visit my GitHub repository:
https://github.com/dipuk0506/dice

Please correct 2 typos and merge.

@dipuk0506
Copy link
Author

Please Merge the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dipuk0506 @imSanko