Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update documentations and tests for fibonacci.cpp #2793

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix: Update documentations and tests for fibonacci.cpp #2793

merged 3 commits into from
Oct 9, 2024

Conversation

ritk20
Copy link
Contributor

@ritk20 ritk20 commented Oct 8, 2024

Description of Change

Adding and updating existing documentation and tests for the algorithm to align with current guidelines.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
fixed fibonacci.cpp according to issue #2456

realstealthninja
realstealthninja requested changes Oct 9, 2024
View reviewed changes
math/fibonacci.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@realstealthninja realstealthninja added the approved Approved; waiting for merge label Oct 9, 2024
@realstealthninja realstealthninja merged commit 512efd1 into TheAlgorithms:master Oct 9, 2024
7 checks passed
@realstealthninja realstealthninja added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritk20 @realstealthninja