-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: pre existing algorithm area.cpp to follow guidelines #2522
Closed
rbevin777
wants to merge
31
commits into
TheAlgorithms:master
from
rbevin777:Fix-pre-existing-algorithm-area.cpp-to-follow-guidelines
+242
−193
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
0741849
chore: removed duplicate header
2c467c9
chore: reordered module doxygen comment
178762e
chore: fixed some of the header documentation.
d29f583
chore: added T parameter tag
fe5980a
chore: added some more tparam tags
c5052e1
chare: note to self about how to tidy this module.
b24c2e6
Merge branch 'TheAlgorithms:master' into Fix-pre-existing-algorithm-a…
rbevin777 093b648
fix: specific data types for area calculation
15aafe0
chore: using wider data type for square area
e5aa286
fix: specified specific types for rectangle area calculation
2d35c53
fix: fixed type issue with triangle area
fe85a0e
fix: set specific data types for area of circle
c4e1850
fix: updated parallelogram function
04c7447
fix: cube surface area function
404036b
fix: sphere surface area funcion
e322c7f
docs: updated function comments
53e8d6b
fix: fixed cylinder surface area functionality
20ccc36
test: removed bulky test case
dd21680
Merge commit 'b24c2e607bcb42f10643317520bc7db02b043738' into Fix-pre-…
6dc4662
Merge branch 'TheAlgorithms:master' into Fix-pre-existing-algorithm-a…
rbevin777 ba3f7a3
chore: added some more comments and added another test
a886cf7
fix: removed undeclared variables
06be4e8
fix: removed unused functions
3b02ed3
docs: updated gherkin test comments.
ac1db38
chore: added triangle area test
55248bd
Merge commit '6dc46621ad83655f522a7ea93b8a0fd238f936e5' into Fix-pre-…
47d72d5
docs: added correct docs name
c375cdf
chore: added circle area test
005d4d5
chore: added parallelogram area test.
6020dba
chore: added cube surface area test
bd6726f
chore: added tests now one for each function.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: added cube surface area test
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please condense all these tests into a single function i.e