Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fit factorial.cpp to contribution guidelines #2487

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

realstealthninja
Copy link
Collaborator

Description of Change

fixed documentation of factorial.cpp
added much needed tests
added an exception so that numbers larger than an unsigned 64 bit integer is not used as an argument

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: part of #2456

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 16, 2023
math/factorial.cpp Show resolved Hide resolved
math/factorial.cpp Outdated Show resolved Hide resolved
math/factorial.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀
Will be merging in a few days if there are no objections. In case I forget, feel free to ping me. 🙂

@realstealthninja
Copy link
Collaborator Author

@Panquesito7

@Panquesito7 Panquesito7 merged commit 37aae7c into TheAlgorithms:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants