fix:Fit Binominal calculate.cpp to guidelines
#2464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX: altered the structure of if else if statements to have guard clauses first before main functionality, added brackets to make calculation steps more clear (Following BODMAS), updated namespaces used in file, removed unneeded user input code CHORE: Added explanations and other documentation
|
maybe we should change the file name to just be |
realstealthninja
requested changes
May 23, 2023
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
|
part of #2456. |
added latex, changed namespace back to binomial
…us-Plus into binomial_calculate
Panquesito7
added
Improvement
Panquesito7
requested changes
May 31, 2023
alexpantyukhin
approved these changes
Jun 5, 2023
Panquesito7
requested changes
Jun 8, 2023
I thought to do this before but forgot to actually do it, whoops!
Panquesito7
reviewed
Jun 9, 2023
Co-authored-by: David Leal <[email protected]>
realstealthninja
requested changes
Jul 5, 2023
| * @namespace binomial | ||
| * @brief Functions for [Binomial | ||
| * coefficients](https://en.wikipedia.org/wiki/Binomial_coefficient) | ||
| * implementation | ||
| */ | ||
| namespace binomial { | ||
| namespace math { namespace binomial { |
There was a problem hiding this comment.
this needs to be documented as well
| * @namespace binomial | ||
| * @brief Functions for [Binomial | ||
| * coefficients](https://en.wikipedia.org/wiki/Binomial_coefficient) | ||
| * implementation | ||
| */ | ||
| namespace binomial { | ||
| namespace math { namespace binomial { |
There was a problem hiding this comment.
Suggested change
| namespace math { namespace binomial { | |
| namespace math { | |
| namespace binomial { |
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
FIX: altered the structure of if else if statements to have guard clauses first before main functionality, added brackets to make calculation steps more clear (Following BODMAS), updated namespaces used in file, removed unneeded user input code
CHORE: Added explanations and other documentation
Checklist
Notes: still no clangd working for me, file may need checked
I'm pretty sure I could do a recursive version of this code, should I make one and add it as a function to this file?