drt: Transform slight refactoring #6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnmfw
force-pushed
the
drt_transform_refactor
branch
from
262bc96 to
a82e60e
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: bernardo <[email protected]>
bnmfw
force-pushed
the
drt_transform_refactor
branch
from
a82e60e to
8129fda
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
osamahammad21
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is auxiliary to #6326, regarding issue #5712.
The aforementioned PR is failing a regression test, I'm hunting the reason for this failing. This is probability due to setting some Transform "by hand" instead of taking it from another object, as is a problem on the whole drt codebase that is being fixed. I organized some of the Transform on drt to help find this bug and figured this was getting big enough to be a separate PR since it is just minor refactoring. Mainly, This PR avoids the direct creation of
dbTransformon drt and opts to get from already set objects when available.