-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: set thread count before grt to use parallel repair_antennas #5345
test: set thread count before grt to use parallel repair_antennas #5345
Conversation
Signed-off-by: Eder Monteiro <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
test/flow.tcl
Outdated
@@ -191,6 +191,8 @@ write_verilog $verilog_file | |||
################################################################ | |||
# Global routing | |||
|
|||
set_thread_count [exec getconf _NPROCESSORS_ONLN] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to put this at the start of the flow? It won't make much difference today but it could in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would affect macro placement because mpl2 produces different results when using multithreaded (@AcKoucher, please correct me if I'm wrong), but we're not using it in the regressions, so it should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problems with mpl2 generating different results for different number of threads were solved a while ago. It should be fine.
Signed-off-by: Eder Monteiro <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
@maliberty I see this failure in the CI:
But I can't reproduce it on my GCP machine. We have another source of possible non-determinism since this metric is generated before grt. I can't download the artifacts of this design from the CI. Is there a way to access it? It would be nice to see where the discrepancies begin. |
It has only for sky130hs/gcd. |
Signed-off-by: Eder Monteiro <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Closing it due to instability in the results. Will create a new PR from the latest master branch to check if the instability persists. |
No description provided.