grt: parallel getOverflow3D #5215
Open
+20
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grzegorz Latosinski <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
maliberty
requested changes
Jun 9, 2024
Comment on lines
+2461
to
+2464
| for (int iter = 0; iter < num_layers_ * y_grid_ * x_grid_; iter++) { | ||
| int k = iter / kstep; | ||
| int i = (iter % kstep) / istep; | ||
| int j = (iter % kstep) % istep; |
There was a problem hiding this comment.
It think it would be simpler to keep the original loop structure and apply collapse(2) to the prama. The original loop was over h_used_ggrid_ rather than all points.
Comment on lines
+2465
to
+2466
| int overflow = h_edges_3D_[k][i][j].usage - h_edges_3D_[k][i][j].cap; | ||
| H_overflow += overflow > 0 ? overflow : 0; |
There was a problem hiding this comment.
I find
const auto& h_edge = h_edges_3D_[k][i][j];
H_overflow += std::max(h_edge.usage - h_edge.cap, 0);
clearer. Likewise V
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completing PR #4636