flow: convert DONT_USE to text files if GZ, ensure files are read as … #373
Conversation
…ASCII, and fix attribute statement yosys does not parse correctly Signed-off-by: Peter Gadfort <[email protected]>
Signed-off-by: Peter Gadfort <[email protected]>
| else: | ||
| f = open(args.inputFile) | ||
| f = open(args.inputFile, encoding="ascii") |
There was a problem hiding this comment.
Based on your comments today, do you need to use utf8?
There was a problem hiding this comment.
When I read it as acsii, the characters are ignored, so it has the same effect as reading it as uft-8 and then converting (except being a little simpler)
There was a problem hiding this comment.
I was wrong, I had the wrong version of the file copied in
| @@ -45,6 +45,12 @@ | |||
| content, count = re.subn(pattern, replace, content) | |||
| print("Commented", count, "lines containing \"original_pin\"") | |||
|
|
|||
| # Yosys, does not like properties that start with : !, without quotes | |||
There was a problem hiding this comment.
I know I'm necroposting, but I'm revisiting the necessity for this script from the yosys side. Is this a workaround for YosysHQ/yosys#3498 which has been fixed?
cc @povik
There was a problem hiding this comment.
Highly likely, you can try removing those lines (file is currently called preprocessLib.py) and see if it still works as intended. I think I recall that it used to emit a warning that it was ignoring the cell, not error out.
…ASCII, and fix attribute statement yosys does not parse correctly