Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added music files from engine #1

Merged
merged 2 commits into from
Nov 5, 2014
Merged

Conversation

msteiger
Copy link
Member

@Cervator
Copy link
Member

Thanks a bunch for this :-)

I want to get this set up but hope you don't mind me asking we do a bit of reorganizing first.

I pinged @ChrisKoebke on Skype seeing if we could have him check in the full soundtrack volume 1 + 2 to the respective repos, as I'd like to drag his user account into it all as well as get all the pieces instead of just the few we already had in the engine :D

He said he could do so on Saturday, so I'll pester him again then

Also, we have a few pieces (included in this PR) that aren't actually from Chris. I'd rather leave them behind or put them in their own repos so this just contains Chris' vol1 stuff.

Finally, can we put the code into its own module, MusicDirector? That way you'll be able to make the soundtrack modules depend on the Directory and have its code be independent. In the future I'd like to see us enhance it further to contain a generic music association system :-)

@msteiger
Copy link
Member Author

msteiger commented Nov 3, 2014

MusicDirector has been set up. Any news from @ChrisKoebke ?

@Cervator
Copy link
Member

Cervator commented Nov 3, 2014

Nope, poked him via Skype Saturday but didn't hear back :-(

Poked him again just now but harder to coordinate on weekdays. If we don't get it done in the ideal fashion soon maybe we just pull the full volume 1 soundtrack off soundcloud, convert to decently sized ogg files and drop in here. Can always give volume 2 a little more time, and/or just have him check in stuff to the Meta repos :-)

@msteiger msteiger force-pushed the master branch 2 times, most recently from 9b33237 to 4542848 Compare November 5, 2014 20:40
Cervator added a commit that referenced this pull request Nov 5, 2014
Added music files from engine
@Cervator Cervator merged commit 971171b into Terasology:master Nov 5, 2014
@Cervator
Copy link
Member

Cervator commented Nov 5, 2014

Thanks :-)

@ChrisKoebke - if you want to later update these files to tweak at quality or just get your username affiliated with them feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants