Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

完全使用 BindingPolicy 替代已有的增强服务绑定逻辑（删除 region、specifications） #1832

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

完全使用 BindingPolicy 替代已有的增强服务绑定逻辑（删除 region、specifications） #1832

wants to merge 7 commits into from

Conversation

piglei
Copy link
Collaborator

@piglei piglei commented Dec 23, 2024

  • 完全使用 BindingPolicy 替换已有的增强服务绑定逻辑
  • 删除增强服务公共 API 中的 region
  • 删除增强服务公共 API 中的 specifications
  • 优化与调整对应的测试代码

SheepSheepChen
SheepSheepChen approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@SheepSheepChen SheepSheepChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apiserver/paasng/paasng/accessories/servicehub/local/manager.py Outdated Show resolved Hide resolved
@piglei
feat: implement service binding using the first available plan and up…
2eca8ac 
…date serializers to support plan_id and env_plan_id_map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayuan929 jiayuan929 jiayuan929 left review comments

@SheepSheepChen SheepSheepChen SheepSheepChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piglei @jiayuan929 @SheepSheepChen