WIP: feat: svc-rabbitmq 支持 plan 管理配置 #1810
Open
+243
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SheepSheepChen
commented
Dec 17, 2024
SheepSheepChen
commented
- 现有方案通过 Cluster 管理 rabbitmq 集群配置
- 增强服务的设计是通过 Plan.config 管理相关配置
jiayuan929
reviewed
Dec 18, 2024
piglei
reviewed
Dec 19, 2024
SheepSheepChen
changed the title
narasux
reviewed
Dec 23, 2024
| api_url = serializers.CharField(required=False, allow_null=True, default=None) | ||
| admin = serializers.CharField(default="admin") | ||
| password = serializers.CharField(required=True) | ||
| cluster_version = serializers.CharField(default="3.7.8") |
narasux
reviewed
Dec 23, 2024
| cluster_version = serializers.CharField(default="3.7.8") | ||
| management_api = serializers.SerializerMethodField(help_text="管理接口") | ||
|
|
||
| def get_management_api(self, obj): |
narasux
reviewed
Dec 23, 2024
| cluster = self.filter(id=plan_config.get("cluster_id")) | ||
| cluster.delete() | ||
|
|
||
| def filter_not_from_plan(self) -> models.QuerySet: |
There was a problem hiding this comment.
这个函数名有点 emmm，换个名字？比如 exclude_from_plan ?
narasux
reviewed
Dec 23, 2024
|
|
||
| # pk 由 /data/fixtures/default.json 确认 | ||
| plan = Plan.objects.get(pk="843127a9-d7a2-4485-b985-076a9b6695d8") | ||
| config = {"host":"10.0.0.1", "admin":"admin","password":"blueking", "port":5672,"api_port":15672} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.