Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 操作记录列表新增其他模块 #111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LidolLxf
Copy link
Contributor

feat: 操作记录列表新增其他模块

@LidolLxf LidolLxf force-pushed the feat_approve_redesign branch from af46079 to a359313 Compare December 13, 2024 03:31
// DecoratorV2 return audit decorator for to record audit.
func (au *audit) DecoratorV3(kit *kit.Kit, bizID uint32, a *table.AuditField) AuditPrepare {
return initAuditBuilderV3(kit, bizID, a, au)
// DecoratorV3 return audit decorator for to record audit.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和函数名保持一致:Decorator

@@ -220,13 +213,16 @@ func (au *audit) createQuery(kit *kit.Kit, req *pbds.ListAuditsReq) (gen.IAuditD
}

// 仅看上线操作
if req.Operate == string(enumor.PublishReleaseConfig) {
if req.Operate == string(enumor.Publish) {
result = result.Where(audit.Action.Eq(req.Operate))
}

// 仅看失败操作
if req.Operate == string(enumor.Failure) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator 还有 Failure 这个操作吗

Comment on lines 33 to 35
// Publish publish an app's release with its strategy.
// once an app's strategy along with its release id is published,
// all its released config items are effected immediately.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要的话注释一起删了

@LidolLxf LidolLxf force-pushed the feat_approve_redesign branch from b12809f to e175325 Compare December 23, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants